[tor-bugs] #30799 [Core Tor/Tor]: Fix a small memory leak in nt_service_install() in ntmain.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 11 05:18:37 UTC 2019


#30799: Fix a small memory leak in nt_service_install() in ntmain.c
-------------------------------------------------+-------------------------
 Reporter:  xiaoyinl                             |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Very Low                             |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Trivial                              |     Resolution:
 Keywords:  no-backport, 041-can, memory-        |  Actual Points:  0.1
  management, unreachable-code                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready
 * severity:  Minor => Trivial
 * actualpoints:   => 0.1
 * priority:  Low => Very Low
 * points:   => 0.1
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.2.x-final
 * keywords:  ???-backport 041-can => no-backport, 041-can, memory-
     management, unreachable-code


Comment:

 Thanks for this patch!

 I made it into a pull request at:
 https://github.com/torproject/tor/pull/1100

 The fix looks good to me.

 This code is not reachable in any supported tor version, so we don't need
 to backport the fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30799#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list