[tor-bugs] #30784 [Core Tor/Tor]: Windows put its timeval definitions in winsock2.h

[Tor Bug Tracker & Wiki]

#30784: Windows put its timeval definitions in winsock2.h
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  ahf
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  041-should, windows, compilation-    |  Actual Points:
  error, 029-backport-maybe, 034-backport,       |
  035-backport, 040-backport                     |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by saurik):

 So, I'm the reason this ticket exists (having filed a pull request on
 GitHub), and I've now spent some more time trying to figure out why this
 would work for you but not for me; I had originally thought it was because
 I was using MinGW (and so tend to run into issues with subtle differences
 in header files), but when I saw your CI system was using MinGW I figured
 I should dig deeper... and I tracked it down to my toolchain setup
 (incorrectly) having hardcoded WIN32_LEAN_AND_MEAN, which meant that the
 #include you already have for <windows.h> wasn't sufficient, but it should
 have been, so I'm sorry: you can just close this ticket as invalid.
 (Again: sorry.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30784#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online