[tor-bugs] #16564 [Core Tor/Tor]: WIP: Reject bridge descriptors posted to non-bridge authorities (was: Reject bridge descriptors posted to non-bridge authorities)

[Tor Bug Tracker & Wiki]

#16564: WIP: Reject bridge descriptors posted to non-bridge authorities
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  work-in-progress, tor-bridge, easy,  |  Actual Points:  0.6
  intro, ex-sponsor-19                           |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor30-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  tor-bridge, easy, intro, ex-sponsor-19 => work-in-progress,
     tor-bridge, easy, intro, ex-sponsor-19
 * status:  assigned => needs_review
 * actualpoints:  0.5 => 0.6


Comment:

 I would like an initial review of the design of this change:
 https://github.com/torproject/tor/pull/1084

 This pull request:
 * changes the purpose of general-purpose descriptors with bridge-
 distribution-request line to the bridge purpose
 * rejects:
   * bridge descriptors uploaded to a non-bridge authority from relays
   * downloaded bridge descriptors, when expecting relay descriptors
   * controller requests that try to add a bridge descriptor to the list of
 relay descriptors

 I wonder if I am missing some rejection cases, and if those cases are all
 covered by changing the descriptor purpose.

 I still need to write some unit tests, see:
 https://trac.torproject.org/projects/tor/ticket/16564#comment:21

 This branch is based on #30780, because the was_router_added_t changes
 conflict. If #30780 merges to master, I can rebase on master to remove
 those commits from the pull request.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16564#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online