[tor-bugs] #30775 [Core Tor/Tor]: Crash in close_or_reextend_intro_circ() (not released)

[Tor Bug Tracker & Wiki]

#30775: Crash in close_or_reextend_intro_circ() (not released)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs bug 041-must stability        |  Actual Points:
  041-regression                                 |
Parent ID:  #30773                               |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  new => merge_ready
 * cc: asn, nickm, mikeperry (added)
 * reviewer:   => dgoulet


Comment:

 Mike's branch has the appropriate fix:
 https://github.com/torproject/tor/pull/1076

 I agree the fix is correct. Reverting #29034 and simply cleaning up the
 circuit from the HS map (which is what the mark for close is doing thus
 expected) and let the removal of the `hs_ident`/`rend_data` to the circuit
 free function.

 ACK.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30775#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online