[tor-bugs] #30747 [Core Tor/sbws]: Unclear check for skipping scaling due to missing bandwidths or missing descriptors

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Jun 4 02:31:31 UTC 2019


#30747: Unclear check for skipping scaling due to missing bandwidths or missing
descriptors
-------------------------------+-------------------------------
     Reporter:  teor           |      Owner:  (none)
         Type:  defect         |     Status:  new
     Priority:  Medium         |  Milestone:  sbws: 1.1.x-final
    Component:  Core Tor/sbws  |    Version:  sbws: 1.1.0
     Severity:  Normal         |   Keywords:
Actual Points:                 |  Parent ID:  #30733
       Points:                 |   Reviewer:
      Sponsor:                 |
-------------------------------+-------------------------------
 We skip old results when scaling, but there are a few things wrong with
 this check:
 1. It is hard to tell what this line does, because it mixes "and" and "or"
 without brackets: l.desc_bw_obs_last or l.desc_bw_obs_mean and
 l.desc_bw_avg
 2. We skip scaling if any input is missing, but then we check
 desc_bw_obs_type and ignore some inputs
 3. If we are missing a descriptor for long enough, we stop generating
 results for a relay. We could use a substitute value instead.
 {{{
             if not(l.desc_bw_obs_last or l.desc_bw_obs_mean and
 l.desc_bw_avg):
                 log.debug("Skipping %s from scaling, because there were
 not "
                           "descriptor bandwidths.", l.nick)
                 continue
             if desc_bw_obs_type == TORFLOW_OBS_LAST:
                 desc_bw_obs = l.desc_bw_obs_last
             elif desc_bw_obs_type == TORFLOW_OBS_MEAN:
                 desc_bw_obs = l.desc_bw_obs_mean
 }}}
 https://github.com/torproject/sbws/blob/9065848247e49330560a2f73b044fb8c02338b48/sbws/lib/v3bwfile.py#L1244

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30747>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list