[tor-bugs] #31251 [Applications/Tor Browser]: Security Level menu hangs off of the toolbarbutton element when it should hang off of the toolbarbutton's child element with toolbarbutton-icon class

[Tor Bug Tracker & Wiki]

#31251: Security Level menu hangs off of the toolbarbutton element when it should
hang off of the toolbarbutton's child element with toolbarbutton-icon class
--------------------------------------+------------------------------
 Reporter:  pospeselr                 |          Owner:  pospeselr
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201907R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by pospeselr):

 * keywords:  TorBrowserTeam201907 => TorBrowserTeam201907R
 * status:  needs_revision => needs_review


Comment:

 Ok I pushed a fixup commit. I'm now deleting the _anchor and _button
 members from the SecurityLevelButton object when the UI DOM changes.

 I don't remember why that function was marked 'async' and I've verified
 that it now works without it. IIRC there was a bug associated (yep #29554)
 with getting the about:preferences to scroll down to our Security Level
 settings so perhaps async was an attempt of a work-around for that.
 Removed.

 tor-browser: https://gitweb.torproject.org/user/richard/tor-
 browser.git/commit/?h=bug_31251

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31251#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online