[tor-bugs] #29197 [Applications/Tor Launcher]: remove use of overlays from Tor Launcher

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jul 31 18:00:47 UTC 2019


#29197: remove use of overlays from Tor Launcher
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Launcher            |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, ux-team,                   |  Actual Points:
  TorBrowserTeam201907R, tbb-9.0-must-nightly    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mcs):

 * keywords:  ff68-esr, ux-team, TorBrowserTeam201907, tbb-9.0-must-nightly
     => ff68-esr, ux-team, TorBrowserTeam201907R, tbb-9.0-must-nightly
 * status:  new => needs_review


Comment:

 We ended up using the `window.MozXULElement.parseXULToFragment()` function
 that Mozilla added since ESR60, which allows for "overlay-like"
 functionality. Please review, and note that these changes are not
 backwards compatible with pre-ESR68 code.

 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug29197-01&id=8bc4a8869936cfc782d1f4c749f7608ead6ddf18

 Also note that to have a good experience with an ESR68-based Tor Browser
 you will want our patch from #31300 too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29197#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list