[tor-bugs] #30126 [Applications/Tor Browser]: Make Tor Browser on macOS compatible with Apple's notarization

[Tor Bug Tracker & Wiki]

#30126: Make Tor Browser on macOS compatible with Apple's notarization
------------------------------------------------+--------------------------
 Reporter:  gk                                  |          Owner:  tbb-team
     Type:  task                                |         Status:  new
 Priority:  Very High                           |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-security, TorBrowserTeam201907  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:21 gk]:
 > Replying to [comment:20 mcs]:
 >
 > [snip]
 >
 > > It is almost perfect.  Apple complains about the following three files
 which have `sdk 10.7` in the mach-o header:
 > >  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/meek-client
 > >  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/meek-client-
 torbrowser
 > >  Tor Browser.app/Contents/MacOS/Tor/PluggableTransports/obfs4proxy
 > > Is the build process different for those binaries?
 >
 > Those are pure `go` builds. Thus, I suspect we need to find some magic
 way to set the required flags when CGO is not involved. Hrm.

 I suspect that's because we use internal linking mode here which hardcodes
 10.7: https://go-review.googlesource.com/c/go/+/18588/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30126#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online