[tor-bugs] #31203 [Circumvention/Snowflake]: Fix Parse.byteCount in the case of unknown units

[Tor Bug Tracker & Wiki]

#31203: Fix Parse.byteCount in the case of unknown units
-------------------------------------+------------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  defect                   |         Status:  needs_review
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------
Changes (by dcf):

 * status:  reopened => needs_review


Comment:

 {{{#!diff
 From e67a65994319d05fbfd22f00973587c0696ca81d Mon Sep 17 00:00:00 2001
 From: David Fifield <david at bamsoftware.com>
 Date: Thu, 25 Jul 2019 14:32:26 -0600
 Subject: [PATCH] Fix tests for Params.getByteCount.

 They were relying on the Query.parse interface, which was removed
 separately.

 https://bugs.torproject.org/31126#comment:5
 ---
  proxy/spec/util.spec.js | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/proxy/spec/util.spec.js b/proxy/spec/util.spec.js
 index f48365d..6eb5be4 100644
 --- a/proxy/spec/util.spec.js
 +++ b/proxy/spec/util.spec.js
 @@ -238,7 +238,7 @@ describe('Params', function() {

      var DEFAULT = 77;
      var getByteCount = function(query) {
 -      return Params.getByteCount(Query.parse(query), 'param', DEFAULT);
 +      return Params.getByteCount(new URLSearchParams(query), 'param',
 DEFAULT);
      };

      it('supports default values', function() {
 --
 2.11.0

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31203#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online