[tor-bugs] #27385 [Circumvention/Snowflake]: https://snowflake.torproject.org/embed is confusing

[Tor Bug Tracker & Wiki]

#27385: https://snowflake.torproject.org/embed is confusing
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks3                         |          Owner:  arlolra
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Circumvention/Snowflake              |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  snowflake, ux-team, anti-            |  Actual Points:
  censorship-roadmap-july                        |
Parent ID:                                       |         Points:
 Reviewer:  cohosh                               |        Sponsor:
                                                 |  Sponsor28-must
-------------------------------------------------+-------------------------

Comment (by cohosh):

 Overall, I like the code changes and refactors. Smaller commits in the
 future would be easier to review for changes like this where it's hard to
 piece together which code was just moved around and where the logic
 changed.

 It looks like `cp -r static/{embed.html,embed.css,popup.js,icons} webext/`
 isn't running properly for some reason. When I run it manually it works,
 but when I ran `npm run webext` to build it, the files didn't copy and it
 fails with the error
 {{{
 The character encoding of the HTML document was not declared. The document
 will render with garbled text in some browser configurations if the
 document contains characters from outside the US-ASCII range. The
 character encoding of the page must be declared in the document or in the
 transfer protocol.
 }}}

 A few comments on the refactoring:
 - WebExtUI and BadgeUI classes were moved to init-webext.js and init-
 badge.js, respectively, but DebugUI is still in ui.js. To follow the
 pattern, should DebugUI be moved to init-test.js? That leaves ui.js pretty
 sparse...
 -
 {{{
 UI.prototype.active = false;

 UI.prototype.enabled = true;
 }}}
  This code might be specific to just WebExtUI. If so we should probably
 move it into that class or init-webext.js.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27385#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online