[tor-bugs] #31234 [Core Tor/Stem]: stem setup.py needs cleanup
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jul 24 20:02:33 UTC 2019
#31234: stem setup.py needs cleanup
---------------------------+-------------------------
Reporter: cypherpunks | Owner: atagar
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Core Tor/Stem | Version:
Severity: Normal | Resolution: wontfix
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------+-------------------------
Changes (by atagar):
* status: new => closed
* resolution: => wontfix
Comment:
> All the large strings should be in separate files.
I prefer this over a separate MANIFEST.in file, but happy to agree to
disagree on this. :)
> setup.py mustn't import the lib its package it is creating
The sole import is to gather our version, author, and other constants. The
only alternative is to duplicate this information which is more error
prone.
> distutils are obsolete
Yup, but also sadly the only python builtin. In our case we don't need any
of the capabilities setuptools provides so it is not worth taking it as a
dependency.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31234#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list