[tor-bugs] #25217 [Metrics]: metrics-base: Update checkstyle to debian stable

[Tor Bug Tracker & Wiki]

#25217: metrics-base: Update checkstyle to debian stable
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  karsten
     Type:  enhancement  |         Status:  needs_review
 Priority:  Low          |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Minor        |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------
Changes (by karsten):

 * status:  assigned => needs_review


Comment:

 Alright, I got it working with Checkstyle 8.15 that comes with Debian
 buster.

 This was not a one-line change, because the .jar file we used earlier
 contained all its dependencies whereas the one that comes with Debian does
 not (which makes sense). That's why we'll have to include a few more
 libraries than just the Checkstyle one. Here's the set of libraries we'll
 have to include, all of which come with buster, too:

 {{{
 diff --git a/java/base.xml b/java/base.xml
 index f484dcd..d377798 100644
 --- a/java/base.xml
 +++ b/java/base.xml
 @@ -58,7 +58,10 @@

    <path id="checkstyle.classpath" >
      <fileset dir="${libs}">
 -      <include name="checkstyle-6.17-all.jar" />
 +      <include name="antlr4-runtime-4.7.2.jar" />
 +      <include name="checkstyle-8.15.jar" />
 +      <include name="commons-collections3-3.2.2.jar" />
 +      <include name="commons-logging-1.2.jar" />
      </fileset>
    </path>
 }}}

 After making this change to metrics-base, `ant checks` runs through, even
 though it prints out this warning that I don't know how to remove:

   ''ANTLR Tool version 4.6 used for code generation does not match the
 current runtime version 4.7.2ANTLR Runtime version 4.6 used for parser
 compilation does not match the current runtime version 4.7.2ANTLR Tool
 version 4.6 used for code generation does not match the current runtime
 version 4.7.2ANTLR Runtime version 4.6 used for parser compilation does
 not match the current runtime version 4.7.2''

 I'd say this warning is acceptable and that we should make this change, in
 an effort to remove the last remaining non-Debian dependency.

 irl, what do you think?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25217#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online