[tor-bugs] #30933 [Circumvention/Snowflake]: Get rid of CoffeeScript from the JS proxy

[Tor Bug Tracker & Wiki]

#30933: Get rid of CoffeeScript from the JS proxy
-------------------------------------+-----------------------------------
 Reporter:  arlolra                  |          Owner:  arlolra
     Type:  defect                   |         Status:  needs_information
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  dcf                      |        Sponsor:
-------------------------------------+-----------------------------------

Comment (by arlolra):

 > 1.
 [https://github.com/keroserene/snowflake/commit/b5934883d45a322dd45f2b7467798ec48b5552e1
 b5934883d4] "Don't overwrite global location": The commit also adds checks
 for `snowflake !== null`. Are those related to the `location` change, or
 could they be split out?

 What was happening was the location bug would throw before `window.init`
 initialized `snowflake` and so `window.unload` would be called with it
 still as `null`.  I can split them apart if you prefer since they're only
 related in that the one surfaced the other.

 > 2.
 [https://github.com/keroserene/snowflake/commit/d1af00da676094a6842501f87faf2367f679cf02
 d1af00da67] "Don't specify port for stun server": How was this working
 before? Was there a hardcoded default inside libwebrtc?

 It wasn't working before because, prior to
 [https://github.com/keroserene/snowflake/commit/7f5cd81f94c530d0142f7caec90581d56a65bafb
 7f5cd81], it wasn't being set at all.  Fixing that "broke" things.

 For what it's worth though, I don't think removing the port actually fixes
 anything.  It probably makes the url invalid in some way that it falls
 back to the default you alluded to in libwebrtc.

 My investigation sort of ended when discovering it was that commit that
 was preventing this work from going through.  We're going to look at it in
 more detail in comment:10:ticket:31100

 > I did the CoffeeScript rebuild step myself starting from
 [https://github.com/keroserene/snowflake/commit/7f5cd81f94c530d0142f7caec90581d56a65bafb
 60fe1ae18b^] and got the same output as your
 [https://github.com/keroserene/snowflake/commit/60fe1ae18b7a1a76a180f6334faa306a64265277
 60fe1ae18b].
 >
 > In order to download the newer version of CoffeeScript needed, I had to
 modify package.json. It might be worth sneaking in a commit to this
 effect, as documentation in the log.
 > {{{#!diff
 > -    "coffee-script": "^1.12.2",
 > +    "coffeescript": "^2",
 > }}}

 Sure, the commit message for
 [https://github.com/keroserene/snowflake/commit/60fe1ae18b7a1a76a180f6334faa306a64265277
 60fe1ae] does mention this though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30933#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online