[tor-bugs] #31081 [Core Tor/Tor]: GETCONF allows zero arguments, contrary to spec

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Jul 6 10:57:50 UTC 2019


#31081: GETCONF allows zero arguments, contrary to spec
-----------------------------------+----------------------------------
 Reporter:  catalyst               |          Owner:  (none)
     Type:  defect                 |         Status:  needs_review
 Priority:  Medium                 |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  tor-control, tor-spec  |  Actual Points:
Parent ID:                         |         Points:  1
 Reviewer:                         |        Sponsor:  Sponsor31-can
-----------------------------------+----------------------------------

Comment (by teor):

 Replying to [comment:1 rl1987]:
 > I propose rejecting `GETCONF` commands with no arguments as they don't
 make sense semantically. The patch turned out to be trivial.
 >
 > https://github.com/torproject/tor/pull/1166

 We talked about rejecting GETCONF with no arguments, but we decided it was
 easier to update the spec. We were concerned that we might break
 controllers that depend on the incorrect behaviour. And it seems like such
 a trivial issue to risk breaking a controller.

 We can talk about it again at our next team meeting, if you'd like.

 If we do decide to reject GETCONF with no arguments, we'll also need to
 change the spec to document the versions that (mistakenly) accepted no
 arguments.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31081#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list