[tor-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

[Tor Bug Tracker & Wiki]

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201903, tbb-8.5,                    |
  TorBrowserTeam201907R                          |
Parent ID:                                       |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by pospeselr):

 Replying to [comment:94 gk]:
 > Okay, here is the status so far. I double-checked all the `widl` sources
 files and it seems only some debugging leftovers slipped into the `tor-
 browser-build` patch (not sure how, though):
 >

 Yeah sorry, I generated the patch from my working winedev3 branch rather
 than winedev2. I've committed a FIXUP patch to my tor-browser-build branch
 with the correct patch :

 https://gitweb.torproject.org/user/richard/tor-browser-
 build.git/commit/?h=bug_27503&id=ce6bc2621c79c3a66cff6f91c0ac38854190e1b0

 And I've rebased my mingw-w64 tree with the correct winedev2 sources:

 https://github.com/pospeselr/mingw-w64/tree/bug_27503


 > Where is `0001-relocatable.patch` is coming from? Is that a custom patch
 you needed to write?

 0001-reloctable.patch lives in /mingw-w64/mingw-w64-tools/widl/patches/ .
 It is not applied at build time during the mingw build process, but is
 instead applied to the widl sources when the latest version is ported
 over, with the resulting patched sources committed to the mingw tree.

 > I still need to figure out what to do with the parser.tab.c,
 parser.tab.h, and parser.yy.c diff.

 Those are generated when building widl within wine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:97>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online