[tor-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

[Tor Bug Tracker & Wiki]

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201903, tbb-8.5,                    |
  TorBrowserTeam201907R                          |
Parent ID:                                       |         Points:
 Reviewer:  boklm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Okay, here is the status so far. I double-checked all the `widl` sources
 files and it seems only some debugging leftovers slipped into the `tor-
 browser-build` patch (not sure how, though):

 parser.y
 {{{
 +       printf("dup_pointer_type!\n");
 +       printf("type : %p name : %s\n", *pt, (*pt)->name);
 +       /* ptr_attr is ref,unique or full (FC_RP, FC_UP, FC_FP) */
 +       /* *pt could be the var's declspec's type OR a type on a typedef
 */
 +       /* not an array */
 }}}
 {{{
 +  printf("reg_type { name : %s, namespace : %s, type : %s, ptr : %p}\n",
 name, namespace->name, ts_to_str(t), type);
 }}}
 (twice)
 {{{
 +          error_loc("FOO %s: redefinition error; original definition was
 at %s:%d\n",
 }}}
 {{{
 +  const var_t *v;
 }}}

 typetree.c
 {{{
 +        error_loc("BAZ %s: redefinition error; original definition was at
 %s:%d\n",
 }}}
 {{{
 +        error_loc("BING %s: redefinition error; original definition was
 at %s:%d\n",
 }}}

 widltypes.h
 {{{
 +static inline const char* ts_to_str(int t)
 +{
 +  static const char* strings[] = {"tsNULL", "tsENUM", "tsSTRUCT",
 "tsUNION"};
 +  return strings[t];
 +}
 +
 }}}


 Where is `0001-relocatable.patch` is coming from? Is that a custom patch
 you needed to write?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:94>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online