[tor-bugs] #30901 [Core Tor/Tor]: Add control port trace logging to tor

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jul 4 02:18:46 UTC 2019


#30901: Add control port trace logging to tor
-----------------------------------+------------------------------------
 Reporter:  teor                   |          Owner:  (none)
     Type:  enhancement            |         Status:  new
 Priority:  Medium                 |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor           |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  tor-ci-fail-sometimes  |  Actual Points:
Parent ID:  #29437                 |         Points:  1
 Reviewer:                         |        Sponsor:  Sponsor31-can
-----------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:5 catalyst]:
 > It occurs to me that if we capture async control event output in these
 log messages, we will have to exclude log events that are sent as async
 control events, to prevent loops.

 Since we want to debug a controller hang, I'd like to avoid modifying the
 control messages entirely.
 Because additional log messages could break or modify the deadlock.

 There's also a module include layering issue: the logging code calls the
 async control code, so the async control code can't include the log
 functions.

 I'd like a set of signal safe logs at debug level, like the error sigsafe
 logs from
 https://github.com/torproject/tor/blob/master/src/lib/err/torerr.c
 But I also need a set of domains for each of those fds.
 At this stage, I don't think we'll need any levels other than debug and
 error, so it's not worth making the code fully generic.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30901#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list