[tor-bugs] #31025 [Core Tor/Tor]: Coverity is confused by switch statement in siphash24 implementation

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jul 3 10:57:43 UTC 2019


#31025: Coverity is confused by switch statement in siphash24 implementation
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  coverity      |  Actual Points:  .1
Parent ID:                |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM! And the siphash unittest  also seem to pass if I toggle the coverity
 flag.

 Let's get this merged and see if it fixes our coverity false positives.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31025#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list