[tor-bugs] #30934 [Circumvention/Snowflake]: Add a "Turn Off/On" toggle

[Tor Bug Tracker & Wiki]

#30934: Add a "Turn Off/On" toggle
-------------------------------------+-----------------------------
 Reporter:  arlolra                  |          Owner:  cohosh
     Type:  defect                   |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  snowflake-webextension   |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  arlolra                  |        Sponsor:
-------------------------------------+-----------------------------

Comment (by cohosh):

 Replying to [comment:5 arlolra]:
 > Looks good to me, just some nits about being consistent with whitespace
 (tabs vs spaces, and all that).
 >
 > > These commits could do with a squashing
 >
 > Also, please rebase your commits on master before merging so that we
 don't have any merge commits.
 >
 Done, and fixed the whitespace errors by moving everything in the
 `webext/` subfolder to the 2 spaces for indentation, no tabs convention.

 > I made a couple of follow up commits that I'd appreciate you having a
 look at in,
 > https://github.com/keroserene/snowflake/commits/webext-toggle

 This look good to me.  I like the cleanup of `cease`/`disable`/`reset`.
 Merged these as well.
 >
 > > I haven't gotten the rotation to work yet with the svg image.
 >
 > Yeah, some sort of indication that it is active would be nice, like
 rotation or switching to green.  Is rotation going to be too distracting
 in the browserAction icon?
 I'll work on this next.
 >
 > A final note is that this doesn't save the toggle state so a user needs
 to turn it on at every browser restart.
 Yeah, I noticed that as well. I think this is okay.. the only thing we'd
 want to save is the displayed stats for:
 {{{Your snowflake has helped 0 users circumvent censorship in the last 24
 hours.}}}
 My guess is that it makes sense to reset this on a browser restart since
 24 hours isn't that long anyway? If we want to allow users to see long-
 term usage we could save this, but is that even a good idea?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30934#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online