[tor-bugs] #27609 [Applications/Tor Browser]: TBA: Evaluate Tor Onion Proxy Library

[Tor Bug Tracker & Wiki]

#27609: TBA: Evaluate Tor Onion Proxy Library
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201901                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by sisbell):

 Replying to [comment:22 akwizgran]:


 > TOPL's OnionProxyManager was originally based on Briar's TorPlugin.
 Changes on the Briar side since the code was forked include support for
 bridges with pluggable transports, so if you're planning to make similar
 changes to TOPL it might make sense to check out the current version of
 TorPlugin:
 >
 This would replace most of the code in OnionProxyManager,
 OnionProxyContext and TorInstaller. Getting connection status is much
 cleaner. The OnionProxyContext would then just be used for getting
 settings and tor config information.

 I think there are 3 primary questions/issues:

 1) We need to override the EventHandler methods so we can send Android
 broadcasts on events but the AndroidTorPlugin class is package-private.
 Does the framework expect/allow plugins from the
 org.briarproject.bramble.plugin.tor package? If this is allowed I could
 just have OnionProxyManager as a subclass of AndroidTorPlugin without a
 lot of modification to the rest of the code.

 2) We need to broadcast event messages and states (like starting and
 stopping) to the UI component in Android. Currently I have an
 EventBroadcaster class that OnionProxyManager uses to broadcast events and
 states during the startup. I see that TorPlugin throws a PluginException
 on failures within the startup. I think this would be workable since I can
 just capture these exceptions external to TorPlugin and then broadcast.
 However, some of the thrown PluginExceptions do not have any message
 passed in. So to be usable, I'd at least need those messages.

 3) EVENTS are not configurable. This is one of the issues I logged with
 TOPL.
 https://github.com/thaliproject/Tor_Onion_Proxy_Library/issues/51

 Overall, it looks good. Thanks for pointing this out.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27609#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online