[tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load extremely
slowly or become unplayable
-------------------------------------------------+-------------------------
 Reporter:  QZw2aBQoPyuEVXYVlBps                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-        |  Actual Points:
  website, TorBrowserTeam201901R                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:16 pospeselr]:
 > This patch looks good to me. You confirmed this issue also works in
 vanilla Firefox right? We should probably open up a issue on bugzilla and
 see about getting this uplifted.
 The behavior is present in vanilla Firefox, though it might be considered
 "working as intended" since in vanilla Firefox you probably wouldn't be
 expected to set the file cache size to 0 like we do.

 There is indeed a comment in the source that points towards this behavior
 being known: "The cache can also be overflowing because the
 media.cache_size preference was reduced." (https://hg.mozilla.org/releases
 /mozilla-
 esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l1162)

 This patch doesn't change the underlying behavior of the file backed
 cache, so the odd loading behavior would still be encountered if you
 forced the Tor Browser out of private browsing.

 It might still be worth pushing this patch upstream though, since in my
 eyes it makes sense to never write to disk in private browsing mode, even
 in vanilla Firefox.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online