[tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

[Tor Bug Tracker & Wiki]

#29080: Merge OrbotService and TOPL
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201901                           |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sisbell):

 I have everything integrated. There are four parts of the project
 currently.

 1) https://github.com/sisbell/Tor_Onion_Proxy_Library
 This is a fork of TOPL with the changes we need for integration with
 OrbotService. I've submitted a pull request. Yaron has some requested
 changes, but they are relatively minor so I'll get this resubmitted this
 week.

 2) https://github.com/sisbell/Tor_Onion_Proxy_Library_Android
 This contains the TOPL android code. Once the changes are merged from (1)
 we can do away with this repo. This project is dependent on (1) and pulls
 it down as part of the build through jitpack

 3) https://github.com/sisbell/tor-android-service
 This contains the merged TOPL and OrbotService code. This project is
 dependent on (2) and pulls it down as part of the build.

 4) https://github.com/sisbell/orbot
 This is a fork of Orbot. I removed the orbotservice code and added the
 dependency on (3). There are no code changes so tor-android-service is
 100% compatible with the current Orbot UI/app implementation.

 {{{
     implementation 'com.github.sisbell:tor-android-
 service:d4deab617b450401b9d5a3aa811ee6cdacaee303'
 }}}
 This repo is just for testing. We will use whatever is going to be
 included in the browser.

 For testing, you can just checkout (4) and import into Android Studio. All
 dependencies are already handled.

 I still need to

  1. Fix changes suggested in the pull request
  1. Add back in code for cookies and hidden services databases.
  1. Do more integration testing to make sure I didn't miss anything
  1. Start tor-browser-build

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29080#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online