[tor-bugs] #29185 [Applications/Tor Browser]: 8.5a7-build3 Windows .exe files are not reproducibly built

[Tor Bug Tracker & Wiki]

#29185: 8.5a7-build3 Windows .exe files are not reproducibly built
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201901,                |  Actual Points:
  GeorgKoppen201901                              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks2):

 {{{
 static LPBYTE generate_icon_group(IconGroup icon, IconPairs order, bool
 first)
 {
   LPBYTE group = new BYTE[
     sizeof(IconGroupHeader) // header
     + order.size() * SIZEOF_RSRC_ICON_GROUP_ENTRY // entries
   ];

   IconGroupHeader* header = (IconGroupHeader*) group;

   header->wReserved = 0;
   header->wIsIcon   = FIX_ENDIAN_INT16(1);
   header->wCount    = FIX_ENDIAN_INT16((WORD)icon.size());

   order = sort_pairs(order, first);

   for (IconGroup::size_type i = 0; i < icon.size(); i++)
   {
     RsrcIconGroupEntry* entry = (RsrcIconGroupEntry*)
       &group[sizeof(IconGroupHeader) + SIZEOF_RSRC_ICON_GROUP_ENTRY * i];
     unsigned index = first ? order[i].index1 : order[i].index2;

     memcpy(&entry->header, &icon[index].meta, sizeof(IconGroupEntry));
     entry->wRsrcId = FIX_ENDIAN_INT16(order[i].size_index + 1);
   }

   return group;
 }
 }}}
 {{{
 #define SIZEOF_RSRC_ICON_GROUP_ENTRY 14
 }}}
 {{{
 typedef struct
 {
   BYTE bWidth;
   BYTE bHeight;
   BYTE bPaletteEntries;
   BYTE bReserved;
   WORD wPlanes;
   WORD wBitsPerPixel;
   DWORD dwRawSize;
 } IconGroupEntry;
 }}}
 Why?

 order.size() == icon.size()? How?

 ZeroMemory for group need.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29185#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online