[tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 25 22:34:16 UTC 2019


#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  041-proposed, tor-client, easy,      |  Actual Points:
  logging, message, usability                    |
Parent ID:                                       |         Points:  .1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by kjak):

 * status:  new => needs_review
 * keywords:  tor-client, easy, logging, message, usability => 041-proposed,
     tor-client, easy, logging, message, usability


Comment:

 Here is a PR to fix this: https://github.com/torproject/tor/pull/669

 I didn't change the overall wording of the error message because
 personally I think it's fine (aside from the IP version mixup).  I think
 it's short and clear and means "You told me to only bind to an IPv4
 address but I couldn't interpret the address as IPv4."

 I took the liberty of also cleaning up the error-checking logic to make it
 a little more precise about what is being checked.  I hope that's OK.

 (I'm also adding the keyword 041-proposed, which my other recent tickets
 got.  Is it OK for me to do that or is adding a keyword like that reserved
 for core team members?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13221#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list