[tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable

[Tor Bug Tracker & Wiki]

#29120: Default value of media.cache_size (0) causes some media to load extremely
slowly or become unplayable
-------------------------------------------------+-------------------------
 Reporter:  QZw2aBQoPyuEVXYVlBps                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-disk-leak, tbb-usability-        |  Actual Points:
  website, TorBrowserTeam201901                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by QZw2aBQoPyuEVXYVlBps):

 Replying to [comment:11 gk]:
 > I  have not looked close at the patch but what we should do in my
 opinion is checking whether we are in private browsing mode and use only
 the memory cache in that case and otherwise we leave the logic as is. Does
 that sound reasonable?
 That seems reasonable, I'm not sure what the best way to check if we're in
 private browsing mode from that section of code is though.

 I can see from the source each media stream in the cache exposes
 {{{mIsPrivateBrowsing}}}, but I'm pretty sure there will be no streams in
 the cache during initialization, so that doesn't do us much good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online