[tor-bugs] #28885 [Applications/Tor Browser]: notify users that update is downloading

[Tor Bug Tracker & Wiki]

#28885: notify users that update is downloading
--------------------------------------+--------------------------------
 Reporter:  mcs                       |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201901      |  Actual Points:
Parent ID:  #25694                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201901R => TorBrowserTeam201901


Comment:

 Here is what I got so far:

 1) I wonder whether we should use a different icon for the download (like
 an arrow *down*) as we have
 the arrow up associaed with *up*date is ready to get applied and this is
 the general Firefox meaning of that icon. I am a bit worried that we set
 user expectations wrong here one can't discriminate between the download
 and ready-to-apply state at a glance.

 2) If one has the about dialog open while a download is happening, closes
 it, opens the hamburger menu and clicks on menuitem then the download
 stops. I guess this is unexpected and should get fixed?
 (Interestingly enough, after clicking the about dialog in that scenario
 and opening it again shows 0 of XX MB at the beginning. It jumps to the
 already download amount (and goes from there) later on when the download
 is resumed. It seems showing "0" in this case is wrong.)

 3) 15:34 <+GeKo> you do
 15:34 <+GeKo> this.showUpdateDownloadingNotification(update, false);
 15:34 <+GeKo> but only have
 15:34 <+GeKo> showUpdateDownloadingNotification()
 15:34 <+GeKo> without any arguments
 15:35 <+GeKo> is that a copy and paste error?

 I applied the Torbutton patch to `master` (commit
 15c369f661fd360c9715b4dd7da147f7aa8f2443), though, to give more time to
 translators.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28885#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online