[tor-bugs] #29040 [Core Tor/Tor]: Tor crashes if ClientOnionAuthDir contains more than one private key for a hidden service

[Tor Bug Tracker & Wiki]

#29040: Tor crashes if ClientOnionAuthDir contains more than one private key for a
hidden service
-------------------------------------------------+-------------------------
 Reporter:  demfloro                             |          Owner:  haxxpop
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.7
 Severity:  Major                                |     Resolution:
 Keywords:  040-proposed, tor-hs, crash,         |  Actual Points:
  035-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by haxxpop):

 Replying to [comment:12 dgoulet]:
 > Replying to [comment:11 haxxpop]:
 > > Replying to [comment:10 nickm]:
 > > > Should this also get fixed in 0.3.5?  If so I want to rebase before
 merging.
 > >
 > > Yes.
 >
 > @haxxpop, this means the branch needs to be based on 035 and not master
 so we can then merge forward. You think you can quickly give us an 035
 branch? Thanks!

 Isn't it already based on 035?

 {{{
 $ git log --oneline --graph
 * 3d635653e hs-v3: add an option param to safe log functions
 * 3842ebac7 hs-v3: fix use after free in client auth config
 *   f8dac5c90 Merge branch 'maint-0.3.5'
 |\
 | *   94a799815 Merge remote-tracking branch 'tlyu-github/ticket28731-035'
 into maint-0.3.5
 | |\
 | | * 1b855af5e Log bootstrap tag names
 * | |   69264f96f Merge branch 'dormant_persist_squashed'
 |\ \ \

 }}}

 Is this one correct?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29040#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online