[tor-bugs] #27503 [Applications/Tor Browser]: Disabling accessibility on Windows breaks screen readers

[Tor Bug Tracker & Wiki]

#27503: Disabling accessibility on Windows breaks screen readers
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  GeorgKoppen201901, TorBrowserTeam201901R       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:
     tbb-8.0-issues, tbb-regression, GeorgKoppen201901,
     TorBrowserTeam201901
     =>
     tbb-8.0-issues, tbb-regression, GeorgKoppen201901,
     TorBrowserTeam201901R
 * status:  needs_information => needs_review


Comment:

 Replying to [comment:28 cypherpunks3]:
 > Jacek's patches landed in Firefox 66 (Firefox Nightly now) which should
 be tested instead of Firefox 64.0.2.

 Nope 64.0.2 was good as the point was to check whether the accessibility
 support Mozilla provides right now is working while the Tor Browser one is
 not (and the former is not related to Jacek's patches).

 So, I think we should move a step forward and test what we get with the
 switch to ESR 60.5.0. At least this allows the workaround in comment:19
 and allows us to shake out more bugs. Additionally, it allows us to start
 from a better position to debug the problem.

 `bug_27503_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/log/?h=bug_27503_v3) in my `tor-browser-build` repo has the two
 fixes for review. We should have committed the first one when fixing
 #28874 but forgot about it. The second one is actually enabling
 accessibility support. To test everything one needs a rebased branch
 against 60.5.0esr, which e.g. be found in #29104.

 Previously, I needed an additional mingw-w64 patch to unbreak the build
 but that's not needed anymore. It's not clear yet why that happens. I
 verified the patches I used back then are the same that are on esr60 and
 the diff between the mingw-w64 versions used then
 (172cf5520c61a607cc5acb59e2709bf303e5ec47) and now
 (2d4e517ad0c7a9f0bd7001c42e6c131b977c15d9) does not show anything obvious.
 I am not complaining... :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27503#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online