[tor-bugs] #29122 [Core Tor/Tor]: Intermittent test failure in circuitpadding/circuitpadding_wronghop

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jan 21 10:39:56 UTC 2019


#29122: Intermittent test failure in circuitpadding/circuitpadding_wronghop
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 The issue here is that sometimes the test will schedule padding using
 timers that will trigger immediately during the test run and hence screw
 up our cell counting tests.

 Here is a good run with stacktraces when `n_client_cells` gets
 incremented:
 {{{
 circuitpadding/circuitpadding_wronghop: [forking] Jan 21 12:28:44.174
 [warn] Bug: . Stack trace: (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(log_backtrace_impl+0x46)
 [0x5601302e6486] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(+0xddd6c) [0x56012fea2d6c] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:
 ./src/test/test(relay_send_command_from_edge___real+0x139)
 [0x5601301af079] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:
 ./src/test/test(circpad_send_command_to_hop__real+0x66) [0x560130187216]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(circpad_negotiate_padding+0x15d)
 [0x560130189afd] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(+0x3c4ced) [0x560130189ced] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(+0xde288) [0x56012fea3288] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(test_circuitpadding_wronghop+0xff)
 [0x56012fea466f] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(+0x373f74) [0x560130138f74] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(testcase_run_one+0x2f1)
 [0x5601301392d1] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(tinytest_main+0x10c)
 [0x5601301398fc] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(main+0x2aa) [0x56012fe4510a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xeb) [0x7f8727f1309b] (on Tor 0.4.0.1
 -alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(_start+0x2a) [0x56012fe4521a] (on
 Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug: . Stack trace: (on Tor 0.4.0.1-alpha-dev
 d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(log_backtrace_impl+0x46)
 [0x5601302e6486] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(+0xddd6c) [0x56012fea2d6c] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:
 ./src/test/test(relay_send_command_from_edge___real+0x139)
 [0x5601301af079] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:
 ./src/test/test(circpad_send_command_to_hop__real+0x66) [0x560130187216]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(circpad_negotiate_padding+0x15d)
 [0x560130189afd] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(test_circuitpadding_wronghop+0xcb3)
 [0x56012fea5223] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(+0x373f74) [0x560130138f74] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(testcase_run_one+0x2f1)
 [0x5601301392d1] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(tinytest_main+0x10c)
 [0x5601301398fc] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(main+0x2aa) [0x56012fe4510a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xeb) [0x7f8727f1309b] (on Tor 0.4.0.1
 -alpha-dev d1af4d65df8b5ef8)
 GOOD  [warn] Bug:     ./src/test/test(_start+0x2a) [0x56012fe4521a] (on
 Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 OK
 1 tests ok.  (0 skipped)
 }}}

 and here is a bad run (see the last increment):
 {{{
 circuitpadding/circuitpadding_wronghop: [forking] Jan 21 12:28:44.234
 [warn] Bug: . Stack trace: (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(log_backtrace_impl+0x46)
 [0x555e4b1bb486] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0xddd6c) [0x555e4ad77d6c] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(relay_send_command_from_edge___real+0x139)
 [0x555e4b084079] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(circpad_send_command_to_hop__real+0x66) [0x555e4b05c216]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(circpad_negotiate_padding+0x15d)
 [0x555e4b05eafd] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0x3c4ced) [0x555e4b05eced] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0xde288) [0x555e4ad78288] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(test_circuitpadding_wronghop+0xff)
 [0x555e4ad7966f] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0x373f74) [0x555e4b00df74] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(testcase_run_one+0x2f1)
 [0x555e4b00e2d1] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(tinytest_main+0x10c) [0x555e4b00e8fc]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(main+0x2aa) [0x555e4ad1a10a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xeb) [0x7f6dd5d4a09b] (on Tor 0.4.0.1
 -alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(_start+0x2a) [0x555e4ad1a21a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug: . Stack trace: (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(log_backtrace_impl+0x46)
 [0x555e4b1bb486] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0xddd6c) [0x555e4ad77d6c] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(relay_send_command_from_edge___real+0x139)
 [0x555e4b084079] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(circpad_send_command_to_hop__real+0x66) [0x555e4b05c216]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(circpad_negotiate_padding+0x15d)
 [0x555e4b05eafd] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(test_circuitpadding_wronghop+0xcb3)
 [0x555e4ad7a223] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0x373f74) [0x555e4b00df74] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(testcase_run_one+0x2f1)
 [0x555e4b00e2d1] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(tinytest_main+0x10c) [0x555e4b00e8fc]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(main+0x2aa) [0x555e4ad1a10a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xeb) [0x7f6dd5d4a09b] (on Tor 0.4.0.1
 -alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(_start+0x2a) [0x555e4ad1a21a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug: . Stack trace: (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(log_backtrace_impl+0x46)
 [0x555e4b1bb486] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0xddd6c) [0x555e4ad77d6c] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(relay_send_command_from_edge___real+0x139)
 [0x555e4b084079] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(circpad_send_command_to_hop__real+0x66) [0x555e4b05c216]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(circpad_send_padding_cell_for_callback+0x103)
 [0x555e4b05dc13] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(timers_run_pending+0x64)
 [0x555e4b15cb64] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0xddc5e) [0x555e4ad77c5e] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(relay_send_command_from_edge___real+0x139)
 [0x555e4b084079] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:
 ./src/test/test(circpad_send_command_to_hop__real+0x66) [0x555e4b05c216]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(circpad_negotiate_padding+0x15d)
 [0x555e4b05eafd] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(test_circuitpadding_wronghop+0xcb3)
 [0x555e4ad7a223] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(+0x373f74) [0x555e4b00df74] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(testcase_run_one+0x2f1)
 [0x555e4b00e2d1] (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(tinytest_main+0x10c) [0x555e4b00e8fc]
 (on Tor 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(main+0x2aa) [0x555e4ad1a10a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xeb) [0x7f6dd5d4a09b] (on Tor 0.4.0.1
 -alpha-dev d1af4d65df8b5ef8)
 BAD [warn] Bug:     ./src/test/test(_start+0x2a) [0x555e4ad1a21a] (on Tor
 0.4.0.1-alpha-dev d1af4d65df8b5ef8)

   FAIL src/test/test_circuitpadding.c:1348: assert(n_client_cells OP_EQ
 2): 3 vs 2
   [circuitpadding_wronghop FAILED]
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29122#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list