[tor-bugs] #26698 [Core Tor/Tor]: Authorities should put a hash of the bandwidth file in their votes

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 18 15:30:17 UTC 2019


#26698: Authorities should put a hash of the bandwidth file in their votes
-----------------------------------------------+---------------------------
 Reporter:  teor                               |          Owner:  (none)
     Type:  enhancement                        |         Status:
                                               |  needs_review
 Priority:  Low                                |      Milestone:  Tor:
                                               |  0.4.0.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-crypto tor-dirauth tor-bwauth  |  Actual Points:
Parent ID:  #27047                             |         Points:
 Reviewer:  nickm                              |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Nickm and teor reviews are not overlapping (except for the `255` typo).
 I made lot of fixups because i moved the hash calculation from the new
 function to `dirserv_read_measured_bandwidths` and i realized about more
 issues on the way.
 I explain each fixup in the PR.
 If you prefer to review a squashed version, see also the comment in the
 PR.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26698#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list