[tor-bugs] #29108 [Core Tor/Tor]: Refactor crypto_digest.c to have fewer ifdefs
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Jan 17 18:29:47 UTC 2019
#29108: Refactor crypto_digest.c to have fewer ifdefs
-------------------------+-------------------------------------------------
Reporter: nickm | Owner: (none)
Type: task | Status: new
Priority: Medium | Milestone: Tor: unspecified
Component: Core | Version:
Tor/Tor | Keywords: 041-proposed refactor technical-
Severity: Normal | debt
Actual Points: | Parent ID:
Points: 1 | Reviewer:
Sponsor: |
Sponsor31-can |
-------------------------+-------------------------------------------------
Our current crypto_digest.c is a maze of twisty little ifdefs, and OpenSSL
keccak support in #28837 will make it even more so. We ought to refactor
it so that it's less idiosyncratic.
Possibly we should take the same approach as in the other crypto_ops
modules, and divide it into an OpenSSL portion, a NSS portion, and a
common portion.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29108>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list