[tor-bugs] #28869 [Core Tor/sbws]: KeyboardInterrupt will cause a callback error and does not close the thread pool cleanly

[Tor Bug Tracker & Wiki]

#28869: KeyboardInterrupt will cause a callback error and does not close the thread
pool cleanly
---------------------------+-----------------------------------
 Reporter:  juga           |          Owner:  (none)
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.2
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28663         |         Points:
 Reviewer:  asn            |        Sponsor:
---------------------------+-----------------------------------
Changes (by juga):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 asn]:
 > Did a review, but it's mostly questions since I'm not that familiar with
 the codebase and this was a bigger patch set than I thought! Feel free to
 correct me wherever I'm blatantly wrong.

 The important changes are:
 - move SIGINT before running the main loop
 - Check end event before starting main loop and before starting new
 measurments, to don't have to wait for them to finish
 - Catch some exceptions earlier, so see them when they happen (and create
 a `ResultError` with them) so that they are not triggered by the callback
 error when finishing.
 - Stop the threads when SIGINT or SIGTERM are triggered.

 I replied to the questions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28869#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online