[tor-bugs] #28142 [Core Tor/Tor]: Merge original WTF-PAD branch

[Tor Bug Tracker & Wiki]

#28142: Merge original WTF-PAD branch
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding                                        |
Parent ID:  #28631                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:34 nickm]:
 > >For monotime, I think my preference would be some kind of check that
 helps decide which of these time abstractions to use, for optimal accuracy
 and speed.
 >
 > I think that might be possible, but it's not going to happen between now
 and the freeze on the 15th.
 >
 > Does the current monotime usage happen in the critical path for default
 tor configurations with this patch?  If no, I think we don't have to block
 on a new monotoime approach.  If yes, maybe we can make it conditional on
 wtf-pad being enabled.

 I think we are good here. Because there are currently no machines enabled
 for any tor configuration, there is no monotime usage happening because of
 circpadding at all. I verified that by adding log messages to monotime
 usage and making sure nothing happens from circuitpadding.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28142#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online