[tor-bugs] #29081 [Applications/Tor Browser]: libwinpthread.dll has no ASLR

[Tor Bug Tracker & Wiki]

#29081: libwinpthread.dll has no ASLR
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-security, tbb-rbm,               |  Actual Points:
  TorBrowserTeam201901R, GeorgKoppen201901       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-security, tbb-rbm, TorBrowserTeam201901, GeorgKoppen201901
     => tbb-security, tbb-rbm, TorBrowserTeam201901R, GeorgKoppen201901
 * status:  new => needs_review


Comment:

 `bug_29081` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_29081&id=358b3b15be6c35810b166625c9331d6ef5071bee)
 has a patch for review. I tested that the flags are right now both for
 i686 and x86_64 and that the library is still built reproducibly.

 It's a bit sad that we can't use `[% c("var/LDFLAGS") %]` easily here and
 thus have to duplicate the flags. But I guess that's okay for now as we
 are moving to mingw-w64/clang anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29081#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online