[tor-bugs] #28780 [Core Tor/Tor]: circpadding: Add machine flag for not closing circuit if machine is active

[Tor Bug Tracker & Wiki]

#28780: circpadding: Add machine flag for not closing circuit if machine is active
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding                                        |
Parent ID:  #28632                               |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Ok I switched to checking the purpose instead of the flag, and removed the
 flag.

 While thinking about #28634, I started to realize we may need more here.
 We may want to flip this back to C_GENERAL isntead of closing it. Or at
 least think about how we would make this circuit behave more like it was
 real. Not sure about hidden service circuits, but general circuits are
 marked dirty and allowed to sit around for 10 minutes after use before
 being closed. I am not sure the best way to do this, though. Maybe we do
 need some kind of timer that does not send a packet but just causes a
 state transition.. Bleh.

 I'm also getting more and more pessimistic about doing this or #28634 by
 Tuesday.. I think it is more important that what we deploy is sane and
 good rather than just does something. I think if we act early enough in
 0.4.1 to make more reasonable machines, we'll have plenty of testing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28780#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online