[tor-bugs] #29072 [Core Tor/Tor]: shellcheck: check-tor issues

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 11 15:52:35 UTC 2019


#29072: shellcheck: check-tor issues
------------------------------+----------------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  technical-debt
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+----------------------------
 {{{

 In check-tor line 36:
         echo ">>" wget --proxy=off -O - http://$ipop/tor/
                                                ^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In check-tor line 37:
         timeout 5 wget --proxy=off -O - http://$ipop/tor/ | head -n3
                                                ^-- SC2086: Double quote to
 prevent globbing and word splitting.


 In check-tor line 41:
 echo -n "$router "; echo "$lines" | grep 'fingerprint' | sed -e 's/^opt
 //' -e 's/^fingerprint //';
      ^-- SC2039: In POSIX sh, echo flags are undefined.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29072>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list