[tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

[Tor Bug Tracker & Wiki]

#29060: shellcheck: test-network.sh issues
------------------------------+----------------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  technical-debt
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+----------------------------
 {{{

 In test-network.sh line 8:
 if [ -d "$CHUTNEY_PATH" -a -x "$TEST_NETWORK" ]; then
                         ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is
 not well defined.


 In test-network.sh line 19:
 myname=$(basename $0)
                   ^-- SC2086: Double quote to prevent globbing and word
 splitting.


 In test-network.sh line 23:
 ORIGINAL_ARGS="$@"
               ^-- SC2124: Assigning an array to a string! Assign as array,
 or use * instead of @ to concatenate.


 In test-network.sh line 55:
     if [ -d "$BUILDDIR/src/core/or" -a -d "$BUILDDIR/src/tools" ]; then
                                     ^-- SC2166: Prefer [ p ] && [ q ] as [
 p -a q ] is not well defined.


 In test-network.sh line 60:
     elif [ -d "$PWD/src/core/or" -a -d "$PWD/src/tools" ]; then
                                  ^-- SC2166: Prefer [ p ] && [ q ] as [ p
 -a q ] is not well defined.


 In test-network.sh line 76:
 if [ ! -d "$CHUTNEY_PATH" -o ! -x "$CHUTNEY_PATH/chutney" ]; then
                           ^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ]
 is not well defined.


 In test-network.sh line 80:
     elif [ -d "$TOR_DIR" -a -d "$TOR_DIR/../chutney" -a \
                          ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ]
 is not well defined.
                                                      ^-- SC2166: Prefer [
 p ] && [ q ] as [ p -a q ] is not well defined.


 In test-network.sh line 97:
 if [ -d "$CHUTNEY_PATH" -a -x "$TEST_NETWORK" ]; then
                         ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is
 not well defined.


 In test-network.sh line 102:
     exec "$TEST_NETWORK" $ORIGINAL_ARGS
                          ^-- SC2086: Double quote to prevent globbing and
 word splitting.

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online