[tor-bugs] #28994 [Core Tor/Tor]: Close stdout pipe on error in process_unix_exec (was double closing stdin pipe)

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 11 14:27:22 UTC 2019


#28994: Close stdout pipe on error in process_unix_exec (was double closing stdin
pipe)
--------------------------+------------------------------------
 Reporter:  kjak          |          Owner:  (none)
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Good catch! That's some bad copy and paste there.

 I think this patch looks good. I don't think we need a changes file when
 this code isn't released yet, but please correct me if I am wrong.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28994#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list