[tor-bugs] #28870 [Core Tor/sbws]: Stop asserting when there's not a descriptor for a relay being measured
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Jan 11 09:48:59 UTC 2019
#28870: Stop asserting when there's not a descriptor for a relay being measured
---------------------------+-----------------------------------
Reporter: juga | Owner: (none)
Type: defect | Status: merge_ready
Priority: Medium | Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws | Version: sbws: 1.0.2
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #28663 | Points:
Reviewer: asn | Sponsor:
---------------------------+-----------------------------------
Changes (by asn):
* status: needs_review => merge_ready
Comment:
`ac9406a` LGTM.
`02bb2f5` also LGTM, but as a nitpick IMO it's a bit sneaky to call this a
'rename' since a rename implies that there is no behavior change, whereas
that commit actually fixes a bug IIUC. I guess this bug went undetected
due to the lack of strong typing in Python and no unittests walking over
it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28870#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list