[tor-bugs] #29017 [Core Tor/Tor]: PaddingStatistics should be disabled when ExtraInfoStatistics is 0

[Tor Bug Tracker & Wiki]

#29017: PaddingStatistics should be disabled when ExtraInfoStatistics is 0
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  fast-fix, 035-backport,              |  Actual Points:  1.1
  034-backport, 033-backport                     |
Parent ID:                                       |         Points:  0.2
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_review
 * actualpoints:  0.2 => 1.1


Comment:

 I tried to start testing router_build_fresh_descriptor(), but it was a
 huge function that looked really hard to test. So I refactored it into
 smaller functions.

 Now I've done the refactor, I can test extrainfo_dump_to_string() using
 just router_build_fresh_unsigned_routerinfo() and
 router_build_fresh_unsigned_extrainfo(). But
 router_build_fresh_unsigned_routerinfo() is also large, so I might re-use
 some of the existing fake test routerinfos.

 In the interim, feel free to review my work in progress refactor in
 https://github.com/torproject/tor/pull/638

 I don't expect that we'll backport this refactor at all: it ended up being
 much larger than I expected. So maybe we'll just have the tests on master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29017#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online