[tor-bugs] #29040 [Core Tor/Tor]: Tor crashes if ClientOnionAuthDir contains more than one public key for a hidden service

[Tor Bug Tracker & Wiki]

#29040: Tor crashes if ClientOnionAuthDir contains more than one public key for a
hidden service
--------------------------+------------------------------
 Reporter:  demfloro      |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Component:  Core Tor/Tor
  Version:  Tor: 0.3.5.7  |       Severity:  Normal
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------
 OS: Arch Linux,

 Minimum torrc to reproduce problem:

 {{{
 ClientOnionAuthDir /var/lib/tor/auth
 }}}
 In /var/lib/tor/auth place a file, for example "key1.auth_private" with:

 {{{
 squlj76moawedtuiixydwlzj65323e6k232bpogd4xrrsz4bgcunyqad:descriptor:x25519:XX5M5YQVTGCXPS3E6G6AGOUZYFISOLMSXLD2E3BTL22DUQZLHK4Q
 }}}
 then do

 {{{
 # cp /var/lib/tor/auth/key1.auth_private
 /var/lib/tor/auth/key2.auth_private
 # tor -f /etc/tor/torrc
 }}}
 This yields the traceback:

 {{{
 Jan 10 03:57:29.597 [notice] Tor 0.3.5.7 running on Linux with Libevent
 2.1.8-stable, OpenSSL 1.1.1a, Zlib 1.2.11, Liblzma 5.2.4, and Libzstd
 1.3.7.
 Jan 10 03:57:29.598 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Jan 10 03:57:29.598 [notice] Read configuration file "/etc/tor/torrc".
 Jan 10 03:57:29.612 [err] tor_assertion_failed_(): Bug:
 src/app/config/config.c:890: get_options_mutable: Assertion global_options
 failed; aborting. (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug: Assertion global_options failed in
 get_options_mutable at src/app/config/config.c:890. Stack trace: (on Tor
 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(log_backtrace_impl+0x48)
 [0x571747260a18] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(tor_assertion_failed_+0x97)
 [0x57174725bee7] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(get_options_mutable+0x60)
 [0x5717471dc1d0] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(safe_str_client+0x22)
 [0x5717471dc552] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:
 tor(hs_config_client_authorization+0x5a0) [0x571747168e10] (on Tor 0.3.5.7
 )
 Jan 10 03:57:29.614 [err] Bug:     tor(hs_config_client_auth_all+0x30)
 [0x5717471fa7f0] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(+0x1798ab) [0x5717471e38ab] (on Tor
 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(options_init_from_string+0x364)
 [0x5717471e7d34] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(options_init_from_torrc+0x376)
 [0x5717471e82f6] (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(tor_init+0x32a) [0x5717470bd7ba]
 (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(tor_run_main+0xcd) [0x5717470be54d]
 (on Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(tor_main+0x3b) [0x5717470bc62b] (on
 Tor 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(main+0x1a) [0x5717470bc1ba] (on Tor
 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:
 /usr/lib/libc.so.6(__libc_start_main+0xf3) [0x74f0206a9223] (on Tor
 0.3.5.7 )
 Jan 10 03:57:29.614 [err] Bug:     tor(_start+0x2e) [0x5717470bc21e] (on
 Tor 0.3.5.7 )

 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29040>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online