[tor-bugs] #24953 [Core Tor/Fallback Scripts]: In check_existing mode, log "fallback list", not "whitelist"

[Tor Bug Tracker & Wiki]

#24953: In check_existing mode, log "fallback list", not "whitelist"
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Fallback Scripts            |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  fast-fix, fallback,                  |  Actual Points:
  034-triage-20180328, 034-removed-20180328,     |
  035-triaged-in-20180711                        |
Parent ID:                                       |         Points:  0.2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Thanks for this patch.

 These changes are good, but we want to use "whitelist" in the default
 mode, and "fallback list" in check_existing mode.
 (The script can run in two modes:
 https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L5
 )

 This is how the modes are implemented:
 https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L2210
 You could add a "type" key to the "whitelist" dictionary, and then use it
 in the strings.

 We also need to change "whitelist" in summarise_fallbacks:
 https://github.com/torproject/tor/blob/master/scripts/maint/updateFallbackDirs.py#L2206

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24953#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online