[tor-bugs] #28851 [Core Tor/Tor]: Do we really need to check our hardwired DH primes at startup?

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jan 2 22:28:57 UTC 2019


#28851: Do we really need to check our hardwired DH primes at startup?
-----------------------------------------------+---------------------------
 Reporter:  nickm                              |          Owner:  nickm
     Type:  defect                             |         Status:
                                               |  needs_revision
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.4.0.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.3.4.9
 Severity:  Normal                             |     Resolution:
 Keywords:  startup performance  035-backport  |  Actual Points:  0
Parent ID:  #28481                             |         Points:
 Reviewer:  asn                                |        Sponsor:
                                               |  Sponsor8-can
-----------------------------------------------+---------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Let's add a comment explaining why we have disabled this code? Or just
 delete it entirely?
 I'm afraid that just doing `#if 0` like that can be confusing and/or
 dirty.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28851#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list