[tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

[Tor Bug Tracker & Wiki]

#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3,         |  Actual Points:
  TorBrowserTeam201902                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by gk):

 antonela: What about

 https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-
 android-armv7-multi-qa-28329_v2.apk
 https://people.torproject.org/~gk/testbuilds/tor-browser-tbb-nightly-
 android-armv7-multi-qa-28329_v2.apk.asc

 ?

 I don't get it to crash on my phone. The patch I used on top of sysrqb's
 is:
 {{{
 diff --git
 a/mobile/android/base/java/org/mozilla/gecko/torbootstrap/TorBootstrapPanel.java
 b/mobile/android/base/java/org/mozilla/gecko/torbootstrap/TorBootstrapPanel.java
 index 743842dca88d..e097a31abb2c 100644
 ---
 a/mobile/android/base/java/org/mozilla/gecko/torbootstrap/TorBootstrapPanel.java
 +++
 b/mobile/android/base/java/org/mozilla/gecko/torbootstrap/TorBootstrapPanel.java
 @@ -170,16 +170,16 @@ public class TorBootstrapPanel extends FirstrunPanel
 implements TorBootstrapLogg
          }
          connectButton.setVisibility(View.GONE);

 -        ImageView spinningOnionHolder = (ImageView)
 mRoot.findViewById(R.id.tor_bootstrap_onion);
 +        //ImageView spinningOnionHolder = (ImageView)
 mRoot.findViewById(R.id.tor_bootstrap_onion);

 -
 spinningOnionHolder.setBackgroundResource(R.drawable.tor_spinning_onion);
 -        AnimationDrawable spinningOnion = (AnimationDrawable)
 spinningOnionHolder.getBackground();
 +
 //spinningOnionHolder.setBackgroundResource(R.drawable.tor_spinning_onion);
 +        //AnimationDrawable spinningOnion = (AnimationDrawable)
 spinningOnionHolder.getBackground();

          // Begin spinning
 -        spinningOnion.start();
 +        //spinningOnion.start();

          // Make the still image 100% transparent
 -        spinningOnionHolder.setImageAlpha(0);
 +        //spinningOnionHolder.setImageAlpha(0);

          TextView torStatus = (TextView)
 mRoot.findViewById(R.id.tor_bootstrap_last_status_message);

 @@ -201,13 +201,13 @@ public class TorBootstrapPanel extends FirstrunPanel
 implements TorBootstrapLogg
          }
          connectButton.setVisibility(View.VISIBLE);

 -        ImageView spinningOnionHolder = (ImageView)
 mRoot.findViewById(R.id.tor_bootstrap_onion);
 -        if (null == spinningOnionHolder) {
 +        //ImageView spinningOnionHolder = (ImageView)
 mRoot.findViewById(R.id.tor_bootstrap_onion);
 +        /*if (null == spinningOnionHolder) {
              Log.w(LOGTAG, "stopBootstrapping: spinningOnionHolder is
 null?");
              return;
 -        }
 -        AnimationDrawable spinningOnion = (AnimationDrawable)
 spinningOnionHolder.getBackground();
 -        if (null != spinningOnion) {
 +        }*/
 +        //AnimationDrawable spinningOnion = (AnimationDrawable)
 spinningOnionHolder.getBackground();
 +        /*if (null != spinningOnion) {
              // Stop spinning. This is null if we didn't
              // previously call startBootstrapping.
              spinningOnion.stop();
 @@ -215,7 +215,7 @@ public class TorBootstrapPanel extends FirstrunPanel
 implements TorBootstrapLogg
              // Make the still image 0% transparent, but only
              // if there is an animation in the background
              spinningOnionHolder.setImageAlpha(100);
 -        }
 +        }*/

          TextView torStatus = (TextView)
 mRoot.findViewById(R.id.tor_bootstrap_last_status_message);
          if (null == torStatus) {
 }}}
 which just disables the animation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online