[tor-bugs] #29585 [Core Tor/Tor]: Intermittent test failures in dir/dirserv_read_measured_bandwidths

[Tor Bug Tracker & Wiki]

#29585: Intermittent test failures in dir/dirserv_read_measured_bandwidths
------------------------------------------+--------------------------------
 Reporter:  teor                          |          Owner:  (none)
     Type:  defect                        |         Status:  new
 Priority:  High                          |      Milestone:  Tor:
                                          |  unspecified
Component:  Core Tor/Tor                  |        Version:  Tor:
                                          |  unspecified
 Severity:  Normal                        |     Resolution:
 Keywords:  tor-ci, tor-test, tor-bwauth  |  Actual Points:
Parent ID:                                |         Points:  1
 Reviewer:                                |        Sponsor:
------------------------------------------+--------------------------------

Comment (by teor):

 Replying to [comment:4 juga]:
 > Replying to [comment:3 juga]:
 > > This means you've merged 065e7da8e6 on top of 69238ca2da?
 >
 > I did that and run the tests, no error.

 I only saw the error once. I don't know how often it happens.

 Replying to [comment:3 juga]:
 > Replying to [ticket:29585 teor]:
 > > {{{
 > > commit 5614960e94 (HEAD, tor-github/pr/723/merge)
 > > Merge: 69238ca2da 065e7da8e6
 > > }}}
 >
 > This means you've merged 065e7da8e6 on top of 69238ca2da?

 This is the merge HEAD of a GitHub pull request:
 https://github.com/torproject/tor/pull/723

 GitHub automatically merged torproject:master and nmathewson:bug29541.

 > > Here is the test error:
 > > {{{
 > > dir/dirserv_read_measured_bandwidths: [forking]
 > >   FAIL ../src/test/test_dir.c:1802: assert(0 OP_EQ
 dirserv_read_measured_bandwidths(fname, NULL, bw_file_headers, NULL)): 0
 vs -1
 > >   [dirserv_read_measured_bandwidths FAILED]
 > > }}}
 > >
 > > It looks like this test was last modified in #26698 in master.
 > >
 > > Is it an obvious fix?
 >
 > Not obvious to me, since they don't touch same files.

 Unstable tests can fail, even if there are no changes to any code run by
 that test.

 Is there an obvious error in dirserv_read_measured_bandwidths that caused
 the failure?
 Can we fix that error?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29585#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online