[tor-bugs] #29599 [Core Tor/Tor]: Test failure due to missing sr_state_free[_all]() in shared-random unit tests

[Tor Bug Tracker & Wiki]

#29599: Test failure due to missing sr_state_free[_all]() in shared-random unit
tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Major                                |     Resolution:
 Keywords:  tor-ci, tor-test, memory-leak,       |  Actual Points:
  external-change, 029-backport, 033-backport,   |
  034-backport, 035-backport, 040-backport       |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review


Comment:

 Here is one of the failed CIs with memory leak logs:
 https://travis-ci.org/tlyu/tor/jobs/499009440#L4956

 Here are the pull requests for review:

 0.2.9 pull request:
 https://github.com/torproject/tor/pull/730

 0.3.3 pull request (function name change):
 https://github.com/torproject/tor/pull/731

 I also did a merge to master to test that there aren't any memory leaks in
 other tests:

 master pull request: (CI only - no changes from 0.3.3)
 https://github.com/torproject/tor/pull/732

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29599#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online