[tor-bugs] #26288 [Core Tor/Tor]: prop289: Implement authenticated SENDME

[Tor Bug Tracker & Wiki]

#26288: prop289: Implement authenticated SENDME
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop289, 035-roadmap-master, 035     |  Actual Points:
  -triaged-in-20180711, prop289-assigned-        |
  sponsor-v, 041-proposed-on-roadmap, network-   |
  team-roadmap-2019-Q1Q2                         |
Parent ID:                                       |         Points:  21
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  SponsorV
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Currently there is a compilation failure on AppVeyor:

 {{{
                  from ../src/core/or/or.h:32,
                  from ../src/core/or/sendme.c:12:
 ../src/core/or/sendme.c: In function
 'sendme_connection_edge_consider_sending':
 ../src/core/or/sendme.c:326:27: error: format '%lu' expects argument of
 type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned
 int}' [-Werror=format=]
      log_debug(log_domain, "Outbuf %lu, queuing stream SENDME.",
                            ^
 ../src/lib/log/log.h:243:48: note: in definition of macro 'log_debug'
        log_fn_(LOG_DEBUG, domain, __FUNCTION__, args, ##__VA_ARGS__); \
                                                 ^~~~
 }}}

 Looks like the test failures on Travis isn't related to this code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26288#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online