[tor-bugs] #29530 [Core Tor/Tor]: Some address/get_if_addrs* tests fail when the network is unreachable

[Tor Bug Tracker & Wiki]

#29530: Some address/get_if_addrs* tests fail when the network is unreachable
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.8
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-test, regression, tor-ci, fast-  |  Actual Points:
  fix 035-backport                               |
Parent ID:                                       |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  reopened => needs_review
 * version:  Tor: unspecified => Tor: 0.3.5.8


Comment:

 Replying to [comment:6 bmwiedemann]:
 > This bug also affects 0.3.5.8 ; please backport.

 See my 0.3.5 backport in https://github.com/torproject/tor/pull/727

 I cherry-picked nickm's commit, edited the commit message, and added a
 changes file.
 It merged cleanly to master.

 > When building packages for openSUSE, we do so without any network
 connectivity to ensure no external inputs are used in a build.
 > After the update of 0.3.5.7 to 0.3.5.8 this broke 3 tests.

 Maybe we should run a CI job without the network?
 (It's probably not worth it for a once-off mistake like this, but if it
 keeps happening, let's consider it.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29530#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online