[tor-bugs] #29586 [Core Tor/Tor]: Intermittent test failures in relay/close_circ_rephist

[Tor Bug Tracker & Wiki]

#29586: Intermittent test failures in relay/close_circ_rephist
------------------------------+------------------------------------
 Reporter:  teor              |          Owner:  (none)
     Type:  defect            |         Status:  new
 Priority:  High              |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor      |        Version:  Tor: 0.3.5.2-alpha
 Severity:  Normal            |     Resolution:
 Keywords:  tor-ci, tor-test  |  Actual Points:
Parent ID:                    |         Points:  1
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------------

Old description:

> I observed this failure in 1/10 tests when testing #29541 on commit:
> {{{
> commit 5614960e94 (HEAD, tor-github/pr/723/merge)
> Merge: 69238ca2da 065e7da8e6
> }}}
>
> Here is the test error:
> {{{
> relay/close_circ_rephist: [forking]
>   FAIL ../src/test/test_relay.c:127: assert(find_largest_max(write_array)
> OP_EQ 2*(get_cell_network_size(nchan->wide_circ_ids)
> +TLS_PER_CELL_OVERHEAD)): 0 vs 1082
>   [close_circ_rephist FAILED]
> }}}
>
> It looks like this test was introduced in #23512 for Sponsor Q.
> Is Sponsor Q still open?
>
> Is it an obvious fix?
> If not, let's see if it happens again.

New description:

 I observed this failure once out of about 10 tests when testing #29541 on
 commit:
 {{{
 commit 5614960e94 (HEAD, tor-github/pr/723/merge)
 Merge: 69238ca2da 065e7da8e6
 }}}

 Here is the test error:
 {{{
 relay/close_circ_rephist: [forking]
   FAIL ../src/test/test_relay.c:127: assert(find_largest_max(write_array)
 OP_EQ 2*(get_cell_network_size(nchan->wide_circ_ids)
 +TLS_PER_CELL_OVERHEAD)): 0 vs 1082
   [close_circ_rephist FAILED]
 }}}

 It looks like this test was introduced in #23512 for Sponsor Q.
 Is Sponsor Q still open?

 Is it an obvious fix?
 If not, let's see if it happens again.

--

Comment (by teor):

 Be more precise: it only failed once

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29586#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online