[tor-bugs] #13221 [Core Tor/Tor]: Misleading error messages about bind_ipv4_only and bind_ipv6_only?

[Tor Bug Tracker & Wiki]

#13221: Misleading error messages about bind_ipv4_only and bind_ipv6_only?
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.3.9-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  041-proposed, tor-client, easy,      |  Actual Points:  .1
  logging, message, usability, 029-backport-     |
  maybe, 034-backport-maybe, 035-backport,       |
  040-backport                                   |
Parent ID:                                       |         Points:  .1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * keywords:  041-proposed, tor-client, easy, logging, message, usability =>
     041-proposed, tor-client, easy, logging, message, usability, 029
     -backport-maybe, 034-backport-maybe, 035-backport, 040-backport
 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final
 * version:   => Tor: 0.2.3.9-alpha
 * actualpoints:   => .1


Comment:

 Hi,

 Thanks for this pull request.

 Sorry it's taken a while for us to get to it: many of us were at a
 hackfest in January, then on leave.

 Replying to [comment:8 kjak]:
 > Here is a PR to fix this: https://github.com/torproject/tor/pull/669
 >
 > I didn't change the overall wording of the error message because
 personally I think it's fine (aside from the IP version mixup).  I think
 it's short and clear and means "You told me to only bind to an IPv4
 address but I couldn't interpret the address as IPv4."
 >
 > I took the liberty of also cleaning up the error-checking logic to make
 it a little more precise about what is being checked.  I hope that's OK.

 It looks good to me.

 > (I'm also adding the keyword 041-proposed, which my other recent tickets
 got.  Is it OK for me to do that or is adding a keyword like that reserved
 for core team members?)

 Yes, that's fine. We're still experimenting with our proposed tickets
 process.

 Review:

 There was a failure in one of the jobs due to our stochastic random tests.
 I re-ran the job and it was fine.

 This patch fixes an error that's been around since 2011.
 It's confusing to relay operators, so it is a backport candidate.

 Would you mind rebasing your patch on our maint-0.2.9 branch?
 If you can't, just let us know, and we'll do it eventually.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13221#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online